Messages in this thread | | | Date | Wed, 25 Oct 2023 10:26:39 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v4 3/4] mfd: cs40l50: Add support for CS40L50 core driver |
| |
On Tue, 24 Oct 2023, Jeff LaBundy wrote:
> Hi James, > > Just a few trailing comments on top of Lee's feedback. > > On Wed, Oct 18, 2023 at 05:57:24PM +0000, James Ogletree wrote: > > From: James Ogletree <james.ogletree@cirrus.com> > > > > Introduce support for Cirrus Logic Device CS40L50: a > > haptic driver with waveform memory, integrated DSP, > > and closed-loop algorithms. > > > > The MFD component registers and initializes the device. > > > > Signed-off-by: James Ogletree <james.ogletree@cirrus.com> > > --- > > MAINTAINERS | 2 + > > drivers/mfd/Kconfig | 30 +++ > > drivers/mfd/Makefile | 4 + > > drivers/mfd/cs40l50-core.c | 443 ++++++++++++++++++++++++++++++++++++ > > drivers/mfd/cs40l50-i2c.c | 69 ++++++ > > drivers/mfd/cs40l50-spi.c | 68 ++++++ > > include/linux/mfd/cs40l50.h | 198 ++++++++++++++++ > > 7 files changed, 814 insertions(+) > > create mode 100644 drivers/mfd/cs40l50-core.c > > create mode 100644 drivers/mfd/cs40l50-i2c.c > > create mode 100644 drivers/mfd/cs40l50-spi.c > > create mode 100644 include/linux/mfd/cs40l50.h
Just popping along to say; these are excellent comments Jeff.
Thank you for your review.
-- Lee Jones [李琼斯]
| |