Messages in this thread | | | From | Justin Stitt <> | Date | Wed, 25 Oct 2023 16:41:43 -0700 | Subject | Re: [PATCH] net: phy: tja11xx: replace deprecated strncpy with ethtool_sprintf |
| |
On Sat, Oct 14, 2023 at 7:36 PM Kees Cook <keescook@chromium.org> wrote: > > On Sat, Oct 14, 2023 at 03:55:41AM +0200, Andrew Lunn wrote: > > > I've been told that this whole ethtool API area is considered > > > deprecated. If that holds, then I don't think it's worth adding new > > > helpers to support it when ethtool_sprintf() is sufficient. > > > > I think deprecated is too strong. The current API is not great, so > > maybe with time a new API will emerge. But given there are around 160 > > users of the API, probably over 100 drivers, it will be 20 years or > > more before all that hardware becomes obsolete and the drivers are > > removed. > > > > > Once you're done with the strncpy->ethtool_sprintf conversions I think > > > it would be nice to have a single patch that fixes all of these > > > "%s"-less instances to use "%s". (Doing per-driver fixes for that case > > > seems just overly painful.) > > > > I guess it is the same amount of effort to replace them with > > ethtool_puts()? > > Yup, right. If adding ethtool_puts() makes sense, then I totally agree.
Thanks for the discussion here.
I've sent a series [1] implementing ethtool_puts() and sending out a wave of replacements.
[1]: https://lore.kernel.org/all/20231025-ethtool_puts_impl-v1-0-6a53a93d3b72@google.com/ > > -- > Kees Cook
Thanks Justin
| |