Messages in this thread | | | Date | Wed, 25 Oct 2023 16:27:43 +0900 | Subject | Re: [PATCH] riscv: boot: Fix creation of loader.bin | From | Damien Le Moal <> |
| |
On 10/24/23 23:53, Geert Uytterhoeven wrote: > When flashing loader.bin for K210 using kflash: > > [ERROR] This is an ELF file and cannot be programmed to flash directly: arch/riscv/boot/loader.bin > > Before, loader.bin relied on "OBJCOPYFLAGS := -O binary" in the main > RISC-V Makefile to create a boot image with the right format. With this > removed, the image is now created in the wrong (ELF) format. > > Fix this by adding an explicit rule. > > Fixes: 505b02957e74f0c5 ("riscv: Remove duplicate objcopy flag") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
-- Damien Le Moal Western Digital Research
| |