lkml.org 
[lkml]   [2023]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iosys-map: Rename locals used inside macros
On Tue, Oct 24, 2023 at 01:07:10PM +0200, Michał Winiarski wrote:
>Widely used variable names can be used by macro users, potentially
>leading to name collisions.
>Suffix locals used inside the macros with an underscore, to reduce the
>collision potential.
>
>Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>

`git show --color-words` shows this is doing exactly what it should.

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Maybe note in the commit message the compilation error we get with
clang? Although that's in the xe driver that is still not merged
upstream... so not really required.

thanks
Lucas De Marchi

\
 
 \ /
  Last update: 2023-10-24 15:12    [W:0.073 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site