Messages in this thread | | | Date | Tue, 24 Oct 2023 15:00:30 +0200 | From | Jiri Pirko <> | Subject | Re: [PATCH net-next 1/2] i40e: Do not call devlink_port_type_clear() |
| |
Tue, Oct 24, 2023 at 02:51:08PM CEST, ivecera@redhat.com wrote: >Do not call devlink_port_type_clear() prior devlink port unregister >and let devlink core to take care about it. > >Reproducer: >[root@host ~]# rmmod i40e >[ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared without a software interface reference, device type not supported by the kernel? >[ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared without a software interface reference, device type not supported by the kernel? > >Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") >Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Ivan, I see that even if we have checks and warnings, it is not enough :)
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Btw, some (even brief) cover letter for patchset would be nice.
| |