Messages in this thread | | | Date | Tue, 24 Oct 2023 11:16:40 +0200 | Subject | Re: [PATCH 12/18] dt-bindings: pwm: add binding for mt8365 SoC | From | AngeloGioacchino Del Regno <> |
| |
Il 23/10/23 16:40, Alexandre Mergnat ha scritto: > Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding > along with MT8183 SoC.
MT8365's Display PWM controller IP is the same as MT8183: blah blah blah :-) because saying that it is compatible doesn't mean that it is the same...
That's a nitpick anyway, but whatever - you'll still have to send a v2 of this series, so you have an easy chance to edit the commit description of this one.
Nitpicks apart...
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > index efe0cacf55b7..e4069bcbf8d5 100644 > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > @@ -32,6 +32,7 @@ properties: > - mediatek,mt8188-disp-pwm > - mediatek,mt8192-disp-pwm > - mediatek,mt8195-disp-pwm > + - mediatek,mt8365-disp-pwm > - const: mediatek,mt8183-disp-pwm > > reg: >
| |