lkml.org 
[lkml]   [2023]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate selection
Hey,

On Mon, Oct 23, 2023 at 10:15:36AM +0800, Seven Lee wrote:
> Add input with DMIC slew rate selection
>
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
> .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> index 3e54abd4ca74..5f7f2eed4834 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> @@ -89,6 +89,12 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> default: 3072000
>
> + nuvoton,dmic-slew-rate-selection:
> + description: number from 0 to 7 that sets DMIC slew rate.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 7
> + default: 0

I'd much rather this was an enum of possible values in $unit, than what
appears to be values you want to write to a register.

Cheers,
Conor.

> +
> nuvoton,left-input-single-end:
> description: Enable left input with single-ended settings if set.
> For the headset mic application, the single-ended control is
> @@ -127,6 +133,7 @@ examples:
> nuvoton,jack-insert-debounce = <7>;
> nuvoton,jack-eject-debounce = <0>;
> nuvoton,dmic-clk-threshold = <3072000>;
> + nuvoton,dmic-slew-rate-selection= <0>;
> #sound-dai-cells = <0>;
> };
> };
> --
> 2.25.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-10-23 18:56    [W:0.350 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site