lkml.org 
[lkml]   [2023]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v13 10/10] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller
    On Sat, Oct 07, 2023 at 09:18:06PM +0530, Krishna Kurapati wrote:
    > From: Andrew Halaney <ahalaney@redhat.com>
    >
    > There is now support for the multiport USB controller this uses so
    > enable it.
    >
    > The board only has a single port hooked up (despite it being wired up to
    > the multiport IP on the SoC). There's also a USB 2.0 mux hooked up,
    > which by default on boot is selected to mux properly. Grab the gpio
    > controlling that and ensure it stays in the right position so USB 2.0
    > continues to be routed from the external port to the SoC.
    >
    > Co-developed-by: Andrew Halaney <ahalaney@redhat.com>

    Checkpatch complains about this one too since Andrew is the primary
    author.

    > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
    > [Krishna: Rebased on top of usb-next]
    > Co-developed-by: Krishna Kurapati <quic_kriskura@quicinc.com>
    > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>

    How much co-development did you actually do here? Just rebasing and
    submitting a patch is not enough to warrant shared authorship.

    > ---
    > arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 21 +++++++++++++++++++++
    > 1 file changed, 21 insertions(+)
    >
    > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
    > index b04f72ec097c..6904a4c201ff 100644
    > --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
    > +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
    > @@ -503,6 +503,18 @@ &usb_2_qmpphy0 {
    > status = "okay";
    > };
    >
    > +&usb_2 {
    > + pinctrl-0 = <&usb2_en_state>;
    > + pinctrl-names = "default";
    > +
    > + status = "okay";
    > +};
    > +
    > +&usb_2_dwc3 {
    > + phy-names = "usb2-port0", "usb3-port0";
    > + phys = <&usb_2_hsphy0>, <&usb_2_qmpphy0>;
    > +};

    Sort order and what Konrad said.

    > +
    > &xo_board_clk {
    > clock-frequency = <38400000>;
    > };
    > @@ -655,4 +667,13 @@ wake-pins {
    > bias-pull-up;
    > };
    > };
    > +
    > + usb2_en_state: usb2-en-state {

    Drop "_state" from label.

    > + /* TS3USB221A USB2.0 mux select */
    > + pins = "gpio24";
    > + function = "gpio";
    > + drive-strength = <2>;
    > + bias-disable;
    > + output-low;
    > + };
    > };

    Johan

    \
     
     \ /
      Last update: 2023-10-23 18:31    [W:4.039 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site