Messages in this thread | | | From | Andrey Konovalov <> | Date | Mon, 23 Oct 2023 18:15:54 +0200 | Subject | Re: [PATCH v2 06/19] lib/stackdepot: fix and clean-up atomic annotations |
| |
On Fri, Oct 6, 2023 at 7:22 PM Alexander Potapenko <glider@google.com> wrote: > > On Fri, Oct 6, 2023 at 6:14 PM Alexander Potapenko <glider@google.com> wrote: > > > > On Wed, Sep 13, 2023 at 7:15 PM <andrey.konovalov@linux.dev> wrote: > > > > > > From: Andrey Konovalov <andreyknvl@google.com> > > > > > > Simplify comments accompanying the use of atomic accesses in the > > > stack depot code. > > > > > > Also drop smp_load_acquire from next_pool_required in depot_init_pool, > > > as both depot_init_pool and the all smp_store_release's to this variable > > > are executed under the stack depot lock. > > Maybe add this to the comment before "if (!next_pool_required)" ?
Will do in v3.
Re removed parentheses: will restore them in v3.
Thanks!
| |