Messages in this thread | | | Date | Mon, 23 Oct 2023 17:12:16 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH 1/2] kexec: fix KEXEC_FILE dependencies |
| |
On Mon, Oct 23, 2023 at 06:04:06PM +0200, Arnd Bergmann wrote: > On Mon, Oct 23, 2023, at 17:37, Conor Dooley wrote: > > On Mon, Oct 23, 2023 at 01:01:54PM +0200, Arnd Bergmann wrote: > > >> index 25474f8c12b79..f571bad2d22d0 100644 > >> --- a/arch/riscv/Kconfig > >> +++ b/arch/riscv/Kconfig > >> @@ -687,9 +687,7 @@ config ARCH_SELECTS_KEXEC_FILE > >> select KEXEC_ELF > >> > >> config ARCH_SUPPORTS_KEXEC_PURGATORY > >> - def_bool KEXEC_FILE > >> - depends on CRYPTO=y > >> - depends on CRYPTO_SHA256=y > >> + def_bool y > > > > This being the problem, KEXEC_FILE is 64-bit only. > > > > IIRC I commented on this same thing during the original conversion > > patches. > > Does it work with this patch on top?
Yah, that modification builds.
rv32 being the redheaded stepchild strikes again :!
Cheers, Conor.
> > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -687,7 +687,7 @@ config ARCH_SELECTS_KEXEC_FILE > select KEXEC_ELF > > config ARCH_SUPPORTS_KEXEC_PURGATORY > - def_bool y > + def_bool ARCH_SUPPORTS_KEXEC_FILE > > config ARCH_SUPPORTS_CRASH_DUMP > def_bool y > > > Arnd [unhandled content-type:application/pgp-signature] | |