lkml.org 
[lkml]   [2023]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add WSA2 audio ports IDs
From
Hi Krzysztof,

On 19/10/2023 16:35, Krzysztof Kozlowski wrote:
> Add defines for audio ports used on Qualcomm WSA2 LPASS (Low Power
> Audio SubSystem).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> index 39f203256c4f..c5ea35abf129 100644
> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
> @@ -139,6 +139,11 @@
> #define DISPLAY_PORT_RX_5 133
> #define DISPLAY_PORT_RX_6 134
> #define DISPLAY_PORT_RX_7 135
> +#define WSA2_CODEC_DMA_RX_0 136
> +#define WSA2_CODEC_DMA_TX_0 137
> +#define WSA2_CODEC_DMA_RX_1 138
> +#define WSA2_CODEC_DMA_TX_1 139
> +#define WSA2_CODEC_DMA_TX_2 140
>

Patches looks fine as it is, but do you realize that this s a dead code
w.r.t upstream.
WSA2 is used only with 4 speaker setup and in such cases we use WSA
codec dma to drive 4 channels.

So WSA2 will not be used by itself.
I would prefer support for this to be added when we are really able to
test WSA2 by itself.

thanks,
Srini

> #define LPASS_CLK_ID_PRI_MI2S_IBIT 1
> #define LPASS_CLK_ID_PRI_MI2S_EBIT 2

\
 
 \ /
  Last update: 2023-10-23 10:38    [W:0.077 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site