Messages in this thread | | | Date | Mon, 23 Oct 2023 12:56:48 -0700 | Subject | Re: [PATCH 5.15 000/137] 5.15.137-rc1 review | From | Guenter Roeck <> |
| |
On 10/23/23 11:50, Geert Uytterhoeven wrote: > CC maz > > On Mon, Oct 23, 2023 at 7:17 PM Daniel Díaz <daniel.diaz@linaro.org> wrote: >> On Mon, 23 Oct 2023 at 09:11, Daniel Díaz <daniel.diaz@linaro.org> wrote: >>> On 23/10/23 4:55 a. m., Greg Kroah-Hartman wrote: >>>> This is the start of the stable review cycle for the 5.15.137 release. >>>> There are 137 patches in this series, all will be posted as a response >>>> to this one. If anyone has any issues with these being applied, please >>>> let me know. >>>> >>>> Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000. >>>> Anything received after that time might be too late. >>>> >>>> The whole patch series can be found in one patch at: >>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.137-rc1.gz >>>> or in the git tree and branch at: >>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y >>>> and the diffstat can be found below. >>>> >>>> thanks, >>>> >>>> greg k-h >>> >>> We see lots of errors on Arm 32-bits: >>> >>> -----8<----- >>> /builds/linux/drivers/gpio/gpio-vf610.c:249:11: error: 'IRQCHIP_IMMUTABLE' undeclared here (not in a function); did you mean 'IS_IMMUTABLE'? >>> .flags = IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND >>> ^~~~~~~~~~~~~~~~~ >>> IS_IMMUTABLE >>> /builds/linux/drivers/gpio/gpio-vf610.c:251:2: error: 'GPIOCHIP_IRQ_RESOURCE_HELPERS' undeclared here (not in a function) >>> GPIOCHIP_IRQ_RESOURCE_HELPERS, >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> /builds/linux/drivers/gpio/gpio-vf610.c:251:2: warning: excess elements in struct initializer >>> /builds/linux/drivers/gpio/gpio-vf610.c:251:2: note: (near initialization for 'vf610_irqchip') >>> /builds/linux/drivers/gpio/gpio-vf610.c: In function 'vf610_gpio_probe': >>> /builds/linux/drivers/gpio/gpio-vf610.c:340:2: error: implicit declaration of function 'gpio_irq_chip_set_chip'; did you mean 'gpiochip_get_data'? [-Werror=implicit-function-declaration] >>> gpio_irq_chip_set_chip(girq, &vf610_irqchip); >>> ^~~~~~~~~~~~~~~~~~~~~~ >>> gpiochip_get_data >>> cc1: some warnings being treated as errors >>> ----->8----- >> >> Bisection points to "gpio: vf610: make irq_chip immutable" (upstream >> commit e6ef4f8ede09f4af7cde000717b349b50bc62576). > > IRQCHIP_IMMUTABLE was introduced in commit 6c846d026d490b23 ("gpio: > Don't fiddle with irqchips marked as immutable") in v5.19. > Backporting (part of) that is probably not safe. >
In this context: What exactly does commit e6ef4f8ede09 fix that makes it a stable release candidate ?
Outch, I realize I am violating the new "no more than 15 quoted lines" rule. Sigh.
Guenter
| |