Messages in this thread | | | Date | Mon, 23 Oct 2023 11:17:21 +0800 | Subject | Re: [PATCH] coresight-tpdm: Correct the property name of MSR number | From | Tao Zhang <> |
| |
On 10/20/2023 4:59 PM, Krzysztof Kozlowski wrote: > On 20/10/2023 10:13, Tao Zhang wrote: >>>> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c >>>> index b25284e..97654aa 100644 >>>> --- a/drivers/hwtracing/coresight/coresight-tpdm.c >>>> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c >>>> @@ -892,7 +892,7 @@ static int tpdm_probe(struct amba_device *adev, const struct amba_id *id) >>>> >>>> if (drvdata && tpdm_has_dsb_dataset(drvdata)) >>>> of_property_read_u32(drvdata->dev->of_node, >>>> - "qcom,dsb_msr_num", &drvdata->dsb_msr_num); >>>> + "qcom,dsb-msrs-num", &drvdata->dsb_msr_num); >>> So you never tested your DTS... We can keep asking about this but still >>> testing does not happen :/ >> Since this new property has not been applied on the exist upstream DTS, >> I tested this driver with the >> >> local DTS. Unfortunately, the property name in the local DTS is not >> updated, this is why it is not found > But your local DTS would not pass dtbs_check tests, so that's why I am > saying - you never tested it on mainline kernel.
Thanks, we will add this test in the future to ensure that DTS, doc and driver are consistent.
Best,
Tao
> > Best regards, > Krzysztof >
| |