Messages in this thread Patch in this message | | | From | Su Hui <> | Subject | [PATCH 1/2] phy: mapphone-mdm6600: fix an error code problem in phy_mdm6600_device_power_on | Date | Fri, 20 Oct 2023 17:14:13 +0800 |
| |
When wait_for_completion_timeout() failed, error is assigned '-ETIMEDOUT'. But this error code is never used. Return '-ETIMEDOUT' directly to fix this problem.
Signed-off-by: Su Hui <suhui@nfschina.com> ---
I'm not sure that return directly is true or not, maybe need some process before return directly.
drivers/phy/motorola/phy-mapphone-mdm6600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 1d567604b650..e84e3390bff0 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -421,8 +421,8 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata) dev_info(ddata->dev, "Powered up OK\n"); } else { ddata->enabled = false; - error = -ETIMEDOUT; dev_err(ddata->dev, "Timed out powering up\n"); + return -ETIMEDOUT; } /* Reconfigure mode1 GPIO as input for OOB wake */ -- 2.30.2
| |