Messages in this thread | | | Date | Fri, 20 Oct 2023 14:29:29 -0700 | Subject | Re: [PATCH iwl-next 4/6] i40e: Use DECLARE_BITMAP for flags field in i40e_hw | From | Jacob Keller <> |
| |
On 10/20/2023 12:37 PM, Ivan Vecera wrote: > Convert flags field in i40e_hw from u64 to bitmap and its usage > to use bit access functions and rename the field to 'caps' as > this field describes capabilities that are set once on init and > read many times later. > > Changes: > - Convert "hw_ptr->flags & FLAG" to "test_bit(FLAG, ...)" > - Convert "hw_ptr->flags |= FLAG" to "set_bit(FLAG, ...)" > - Convert "hw_ptr->flags &= ~FLAG" to "clear_bit(FLAG, ...)" > - Rename i40e_hw.flags to i40e_hw.caps > - Rename i40e_set_hw_flags() to i40e_set_hw_caps() > - Adjust caps names so they are prefixed by I40E_HW_CAP_ and existing > _CAPABLE suffixes are stripped > > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
| |