lkml.org 
[lkml]   [2023]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 26/27] staging: iio: resolver: ad2s1210: implement fault events
    On Sat, Sep 30, 2023 at 11:00 AM Jonathan Cameron <jic23@kernel.org> wrote:
    >
    > On Fri, 29 Sep 2023 12:23:31 -0500
    > David Lechner <dlechner@baylibre.com> wrote:
    >
    > > From: David Lechner <david@lechnology.com>
    > >
    > > From: David Lechner <dlechner@baylibre.com>
    > >
    > > When reading the position and velocity on the AD2S1210, there is also a
    > > 3rd byte following the two data bytes that contains the fault flag bits.
    > > This patch adds support for reading this byte and generating events when
    > > faults occur.
    > >
    > > The faults are mapped to various channels and event types in order to
    > > have a unique event for each fault.
    > >
    > > Signed-off-by: David Lechner <dlechner@baylibre.com>
    >
    > Use of x and y modifiers is a little odd. What was your reasoning?
    > Was it just that there was a X_OR_Y modifier? If so, don't use that!
    > It seemed like a good idea at the time, but it's not nice to deal with
    > and requires a channel with that modifier to hang the controls off
    > + make sure userspace expects that event code.
    >

    Yes, I was perhaps getting a bit too creative here (the two inputs
    come from transformers mounted 90 degrees apart so measure X and Y
    component of an angle). The only reason I did this was to take
    advantage of the possibility of an "OR" event to avoid double events
    for a single fault bit. We can just go with the double event on the
    two different input channels as discussed in "[PATCH v3 22/27]
    staging: iio: resolver: ad2s1210: convert LOS threshold to event
    attr".

    \
     
     \ /
      Last update: 2023-10-02 18:43    [W:4.191 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site