Messages in this thread | | | Subject | Re: [PATCH 2/3] platform/x86: ISST : Check major minor version | From | srinivas pandruvada <> | Date | Mon, 02 Oct 2023 07:56:54 -0700 |
| |
On Mon, 2023-10-02 at 17:24 +0300, Ilpo Järvinen wrote: > On Mon, 2 Oct 2023, srinivas pandruvada wrote: > > > On Mon, 2023-10-02 at 16:49 +0300, Ilpo Järvinen wrote: > > > On Sat, 30 Sep 2023, srinivas pandruvada wrote: > > > > > > > On Fri, 2023-09-29 at 17:28 +0300, Ilpo Järvinen wrote: > > > > > On Mon, 25 Sep 2023, Srinivas Pandruvada wrote: > > > > > > > > > > > Parse major and minor version number from the version > > > > > > field. If > > > > > > there > > > > > > is a mismatch for major version, exit from further > > > > > > processing > > > > > > for > > > > > > that > > > > > > domain. > > > > > > > > > > > > If there is mismatch in minor version, driver continue to > > > > > > process > > > > > > with > > > > > > an error message. > > > > > > > > > > This sentence sounds odd. > > > > What is the suggestion here? > > > > > > These things sound wrong: It should be "continues" > > OK > > > > > but I also find "to > > > process" odd when lacking what it processes. > > > > Further processing means, whatever this driver is supposed to do. > > You > > don't want to fully explain again what this driver is doing. > > Well, whatever. I'm not a native anyway so I cannot really be the > defining > authority how the language gets used so feel free to leave "to > process" > as is.'
That is not my intention! I want to make it as good as possible. Let me come up with new description.
Thanks, Srinivas
>
| |