lkml.org 
[lkml]   [2023]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] drm/panel: ili9322: Remove redundant volatle_reg() operation
On 01/10/2023 12:24, Mark Brown wrote:
> The ili9322 driver has a volatile_reg() operation in it's regmap which
> always returns false. This is redundant since it is the default in the
> regmap core, remove the operation for a trivial code size and performance
> improvement.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
> index 61c872f0f7ca..15b81e5228b5 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
> @@ -325,11 +325,6 @@ static struct regmap_bus ili9322_regmap_bus = {
> .val_format_endian_default = REGMAP_ENDIAN_BIG,
> };
>
> -static bool ili9322_volatile_reg(struct device *dev, unsigned int reg)
> -{
> - return false;
> -}
> -
> static bool ili9322_writeable_reg(struct device *dev, unsigned int reg)
> {
> /* Just register 0 is read-only */
> @@ -343,7 +338,6 @@ static const struct regmap_config ili9322_regmap_config = {
> .val_bits = 8,
> .max_register = 0x44,
> .cache_type = REGCACHE_RBTREE,
> - .volatile_reg = ili9322_volatile_reg,
> .writeable_reg = ili9322_writeable_reg,
> };
>
>

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

\
 
 \ /
  Last update: 2023-10-02 08:53    [W:0.116 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site