Messages in this thread | | | Date | Mon, 2 Oct 2023 13:37:52 +0200 | From | David Sterba <> | Subject | Re: [PATCH 05/29] btrfs: move btrfs_xattr_handlers to .rodata |
| |
On Mon, Oct 02, 2023 at 01:28:58PM +0200, David Sterba wrote: > On Sat, Sep 30, 2023 at 02:00:09AM -0300, Wedson Almeida Filho wrote: > > From: Wedson Almeida Filho <walmeida@microsoft.com> > > > > This makes it harder for accidental or malicious changes to > > btrfs_xattr_handlers at runtime. > > > > Cc: Chris Mason <clm@fb.com> > > Cc: Josef Bacik <josef@toxicpanda.com> > > Cc: David Sterba <dsterba@suse.com> > > Cc: linux-btrfs@vger.kernel.org > > Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com> > > With slightly updated changelog added to misc-next, thanks.
Removed again. I did not notice first that this is part of a larger series, please also CC the [PATCH 0/N] patch.
There's a warning:
fs/btrfs/super.c: In function ‘btrfs_fill_super’: fs/btrfs/super.c:1107:21: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 1107 | sb->s_xattr = btrfs_xattr_handlers; | ^
but the patch changing the type is present in the series.
Please update the changelog of btrfs patch with:
Add const specifier also to the pointed array members of btrfs_xattr_handlers. This moves the whole structure to the .rodata section which makes it harder for accidental or malicious changes to btrfs_xattr_handlers at runtime.
or use it for others patches too.
| |