lkml.org 
[lkml]   [2023]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc_cursor"
From
On 10/2/23 12:05, Michel Dänzer wrote:
> On 9/29/23 22:41, Hamza Mahfooz wrote:
>> From: Ivan Lipski <ivlipski@amd.com>
>>
>> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be.
>>
>> Since, it causes the following IGT tests to fail:
>> kms_cursor_legacy@cursor-vs-flip.*
>> kms_cursor_legacy@flip-vs-cursor.*
>
> Any information about how those tests fail? Maybe they accidentally rely on the broken behaviour?

I was able to reproduce, that doesn't seem to be the case. They just rely on multiple legacy cursor ioctl calls being able to complete between consecutive flips, which I suppose is broken by always pulling in non-cursor plane state with any cursor plane state changes.

I'll see if I can find a better solution. Meanwhile,

Acked-by: Michel Dänzer <mdaenzer@redhat.com>

for the revert.


--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer

\
 
 \ /
  Last update: 2023-10-02 12:49    [W:0.045 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site