lkml.org 
[lkml]   [2023]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/29] ext2: move ext2_xattr_handlers and ext2_xattr_handler_map to .rodata
    On Sat 30-09-23 02:00:13, Wedson Almeida Filho wrote:
    > From: Wedson Almeida Filho <walmeida@microsoft.com>
    >
    > This makes it harder for accidental or malicious changes to
    > ext2_xattr_handlers or ext2_xattr_handler_map at runtime.
    >
    > Cc: Jan Kara <jack@suse.com>
    > Cc: linux-ext4@vger.kernel.org
    > Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

    Looks good to me. Feel free to add:

    Acked-by: Jan Kara <jack@suse.cz>

    Honza

    > ---
    > fs/ext2/xattr.c | 4 ++--
    > fs/ext2/xattr.h | 2 +-
    > 2 files changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
    > index 8906ba479aaf..cfbe376da612 100644
    > --- a/fs/ext2/xattr.c
    > +++ b/fs/ext2/xattr.c
    > @@ -98,7 +98,7 @@ static struct buffer_head *ext2_xattr_cache_find(struct inode *,
    > static void ext2_xattr_rehash(struct ext2_xattr_header *,
    > struct ext2_xattr_entry *);
    >
    > -static const struct xattr_handler *ext2_xattr_handler_map[] = {
    > +static const struct xattr_handler * const ext2_xattr_handler_map[] = {
    > [EXT2_XATTR_INDEX_USER] = &ext2_xattr_user_handler,
    > #ifdef CONFIG_EXT2_FS_POSIX_ACL
    > [EXT2_XATTR_INDEX_POSIX_ACL_ACCESS] = &nop_posix_acl_access,
    > @@ -110,7 +110,7 @@ static const struct xattr_handler *ext2_xattr_handler_map[] = {
    > #endif
    > };
    >
    > -const struct xattr_handler *ext2_xattr_handlers[] = {
    > +const struct xattr_handler * const ext2_xattr_handlers[] = {
    > &ext2_xattr_user_handler,
    > &ext2_xattr_trusted_handler,
    > #ifdef CONFIG_EXT2_FS_SECURITY
    > diff --git a/fs/ext2/xattr.h b/fs/ext2/xattr.h
    > index 7925f596e8e2..6a4966949047 100644
    > --- a/fs/ext2/xattr.h
    > +++ b/fs/ext2/xattr.h
    > @@ -72,7 +72,7 @@ extern void ext2_xattr_delete_inode(struct inode *);
    > extern struct mb_cache *ext2_xattr_create_cache(void);
    > extern void ext2_xattr_destroy_cache(struct mb_cache *cache);
    >
    > -extern const struct xattr_handler *ext2_xattr_handlers[];
    > +extern const struct xattr_handler * const ext2_xattr_handlers[];
    >
    > # else /* CONFIG_EXT2_FS_XATTR */
    >
    > --
    > 2.34.1
    >
    --
    Jan Kara <jack@suse.com>
    SUSE Labs, CR

    \
     
     \ /
      Last update: 2023-10-02 11:50    [W:4.174 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site