Messages in this thread | | | From | Alice Ryhl <> | Date | Mon, 2 Oct 2023 10:18:07 +0200 | Subject | Re: [PATCH] rust: Use grep -Ev rather than relying on GNU grep |
| |
On Mon, Oct 2, 2023 at 9:51 AM Alice Ryhl <aliceryhl@google.com> wrote: > > On Thu, Sep 28, 2023 at 10:14 PM Matthew Maurer <mmaurer@google.com> wrote: > > > > While GNU grep supports '\|' when in basic regular expression mode, not > > all grep implementations do (notably toybox grep, used to build the > > Android kernel, does not). Switching to grep -Ev enables extended > > regular expresions which includes support for the '|' operator. > > > > Signed-off-by: Matthew Maurer <mmaurer@google.com> > > LGTM. I tested this in my Android build.
Also tested in a non-Android build. Works both places.
> Reviewed-by: Alice Ryhl <aliceryhl@google.com> > Tested-by: Alice Ryhl <aliceryhl@google.com>
| |