Messages in this thread | | | Date | Thu, 19 Oct 2023 16:35:01 +0200 | Subject | Re: [PATCH v2 1/2] dt-bindings: w1: Add YAML DT schema for AMD AXI w1 host and MAINTAINERS entry | From | Michal Simek <> |
| |
On 10/19/23 16:30, Conor Dooley wrote: > On Thu, Oct 19, 2023 at 07:24:17AM -0700, Kris Chaplin wrote: >> Add YAML DT schema for the AMD AXI w1 host IP. >> >> This hardware guarantees protocol timing for driving off-board devices such >> as thermal sensors, proms, etc using the 1wire protocol. >> >> Add MAINTAINERS entry for DT schema. >> >> Co-developed-by: Thomas Delev <thomas.delev@amd.com> >> Signed-off-by: Thomas Delev <thomas.delev@amd.com> >> Signed-off-by: Kris Chaplin <kris.chaplin@amd.com> >> --- >> .../bindings/w1/amd,axi-1wire-host.yaml | 44 +++++++++++++++++++ >> MAINTAINERS | 7 +++ >> 2 files changed, 51 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml >> >> diff --git a/Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml b/Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml >> new file mode 100644 >> index 000000000000..ef70fa2c0c5d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml >> @@ -0,0 +1,44 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/w1/amd,axi-1wire-host.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: AMD AXI 1-wire bus host for programmable logic >> + >> +maintainers: >> + - Kris Chaplin <kris.chaplin@amd.com> >> + >> +properties: >> + compatible: >> + const: amd,axi-1wire-host > > I was happy with it before, and still am I guess, given that there is an > IP version register that can be used to determine which version of the > IP is in use. > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
I think we discussed that already that identification register should be described as the part of commit message to make this clear.
Thanks, Michal
| |