Messages in this thread | | | Date | Thu, 19 Oct 2023 13:51:45 +0200 | Subject | Re: [PATCH] lib/vsprintf: Remove redundant code | From | Rasmus Villemoes <> |
| |
On 18/10/2023 08.48, Jiapeng Chong wrote: > When variable needcolon is assigned a value of false, it must be > assigned a value of true later on, which is redundant code.
NAK on any patch modifying these things without first filling the blank space in ip6() in lib/test_printf.c with tests for all the various ip6 printing modes.
Adding test cases there is much more useful than code-golfing, and would help verify that these changes are actually ok. Or may reveal that the current code is buggy.
Rasmus
| |