lkml.org 
[lkml]   [2023]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] dt-bindings: iio: light: Squash APDS9300 and APDS9960 schemas
    From
    On 19/10/2023 10:04, Subhajit Ghosh wrote:
    > Squashing Avago (Broadcom) APDS9300 and APDS9960 schemas into one
    > file and removing the other.

    Please answer: why?

    > Link: https://lore.kernel.org/all/4e785d2e-d310-4592-a75a-13549938dcef@linaro.org/
    >
    > Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
    > ---
    > .../bindings/iio/light/avago,apds9300.yaml | 35 ++++++++++++---
    > .../bindings/iio/light/avago,apds9960.yaml | 44 -------------------
    > 2 files changed, 29 insertions(+), 50 deletions(-)
    > delete mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
    > index 206af44f2c43..7826a1749fcd 100644
    > --- a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
    > +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
    > @@ -4,17 +4,26 @@
    > $id: http://devicetree.org/schemas/iio/light/avago,apds9300.yaml#
    > $schema: http://devicetree.org/meta-schemas/core.yaml#
    >
    > -title: Avago APDS9300 ambient light sensor
    > +title: Avago Gesture, RGB, ALS and Proximity sensors
    >
    > maintainers:
    > - Jonathan Cameron <jic23@kernel.org>
    > + - Matt Ranostay <matt.ranostay@konsulko.com>
    >
    > description: |
    > - Datasheet at https://www.avagotech.com/docs/AV02-1077EN
    > + Avago (Broadcom) optical and proximity sensors with I2C interfaces.
    > + Datasheet at https://docs.broadcom.com/doc/AV02-1077EN
    > + Datasheet at https://docs.broadcom.com/doc/AV02-4191EN
    >
    > properties:
    > compatible:
    > - const: avago,apds9300
    > + oneOf:
    > + - items:
    > + - const: avago,apds9300
    > + - const: avago,apds9960


    Why? Commit msg does not explain this.

    > + - enum:
    > + - avago,apds9300
    > + - avago,apds9960
    >
    > reg:
    > maxItems: 1
    > @@ -22,14 +31,28 @@ properties:
    > interrupts:
    > maxItems: 1
    >
    > -additionalProperties: false
    > -
    > required:
    > - compatible
    > - reg
    >
    > +allOf:
    > + - $ref: ../common.yaml#
    > + - if:
    > + properties:
    > + compatible:
    > + contains:
    > + enum:
    > + - avago,apds9960
    > + then:
    > + required:
    > + - interrupts

    Why? This wasn't in original binding.

    > +
    > +additionalProperties: false
    > +
    > examples:
    > - |
    > + #include <dt-bindings/interrupt-controller/irq.h>
    > +
    > i2c {
    > #address-cells = <1>;
    > #size-cells = <0>;
    > @@ -38,7 +61,7 @@ examples:
    > compatible = "avago,apds9300";
    > reg = <0x39>;
    > interrupt-parent = <&gpio2>;
    > - interrupts = <29 8>;
    > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>;

    Separate patch please.

    You are doing way too many unexpected and not explained changes.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-10-19 11:21    [W:6.503 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site