Messages in this thread | | | Date | Thu, 19 Oct 2023 16:05:08 -0500 | Subject | Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller | From | Andrew Davis <> |
| |
On 10/9/23 3:24 AM, Vaishnav Achath wrote: > From: Nishanth Menon <nm@ti.com> > > Use ti,j721e-system-controller to be explicit about the syscon node we > are using. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > > No changes since V1. > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 6ffaf85fa63f..2ee6215e38a6 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -165,7 +165,7 @@ > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
There is already a "ti,j721e-system-controller" in the main domain dtsi. And this is not one of those. You are hiding a valid DT warning by adding an incorrect compatible string that just so happens to not throw the warning.
This should be a "simple-bus" node.
Andrew
> reg = <0x00 0x40f00000 0x00 0x20000>; > #address-cells = <1>; > #size-cells = <1>;
| |