lkml.org 
[lkml]   [2023]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pds_core: add an error code check in pdsc_dl_info_get
From
On 10/19/2023 1:33 AM, Su Hui wrote:
>
> check the value of 'ret' after call 'devlink_info_version_stored_put'.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>

Thanks.

Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

> ---
> drivers/net/ethernet/amd/pds_core/devlink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
> index d9607033bbf2..09041f7fccaf 100644
> --- a/drivers/net/ethernet/amd/pds_core/devlink.c
> +++ b/drivers/net/ethernet/amd/pds_core/devlink.c
> @@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
> snprintf(buf, sizeof(buf), "fw.slot_%d", i);
> err = devlink_info_version_stored_put(req, buf,
> fw_list.fw_names[i].fw_version);
> + if (err)
> + return err;
> }
>
> err = devlink_info_version_running_put(req,
> --
> 2.30.2
>

\
 
 \ /
  Last update: 2023-10-19 17:53    [W:0.219 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site