Messages in this thread | | | Date | Wed, 18 Oct 2023 20:25:58 +0800 | Subject | Re: [PATCH net 5/6] net: hns3: fix wrong print link down up | From | Jijie Shao <> |
| |
on 2023/10/17 21:59, Andrew Lunn wrote > I still think this is totally valid and correct. > > When you turn auto-neg off the link partner is going to react to that, > it might drop the link. After a while, the link partner will give up > trying to perform auto-neg and might fall back to 10/Half. At which > point, the link might allow traffic flow. However, in this example, > you have a duplex mis-match, so it might not work correctly. > > Turning off auto-neg is something you need to do at both ends, and you > need to then force both ends to the same settings. Link down is > expected. I would actually be suppressed if no link down events were > reported. > > Andrew
Hi Andrew, Thank you for your comments, we are re-evaluating this issue and may drop this patch.
Regards Jijie
| |