lkml.org 
[lkml]   [2023]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] staging: rts5208: Replace delay function.
    On Wed, Oct 18, 2023 at 09:32:46AM +0200, Karolina Stolarek wrote:
    > On 18.10.2023 09:03, Julia Lawall wrote:
    > >
    > >
    > > On Tue, 17 Oct 2023, kenechukwu maduechesi wrote:
    > >
    > > > Replace udelay() with usleep_range() for more precise delay handling.
    > > >
    > > > Reported by checkpatch:
    > > >
    > > > CHECK: usleep_range is preferred over udelay
    > >
    > > This message is typically not a good candidate for outreachy patches,
    > > because you need access to the device to be sure that any change is
    > > correct.
    >
    > Could we add a paragraph on how to pick good checkpatch.pl error to fix to
    > the Outreachyfirstpatch docs? This could go to "Find a driver to clean up"
    > section, for example.

    The ability to find a "good" error changes over time, so this might be
    hard to do.

    good luck!

    greg k-h

    \
     
     \ /
      Last update: 2023-10-18 09:46    [W:4.266 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site