Messages in this thread | | | Date | Thu, 19 Oct 2023 10:24:46 +0800 | Subject | Re: [PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace | From | Huan Yang <> |
| |
在 2023/10/19 0:28, Yu Zhao 写道: > On Wed, Oct 18, 2023 at 2:22 AM Huan Yang <link@vivo.com> wrote: >> This patch add two reclaim stat: >> nr_promote: nr_pages shrink before promote by folio_update_gen. >> nr_demote: nr_pages NUMA demotion passed. > The above isn't specific to MLGRU, so they should be in a separate patchset.
OK, nr_demote isn't MGLRU, separate is good, but, if this, nr_demote isn't need by myself, I just add this when I see this code. :) Please see nr_promote and nr_scanned fix is MGLRU need?
> >> And then, use correct nr_scanned which evict_folios passed into >> trace_mm_vmscan_lru_shrink_inactive. >> >> Mistake info like this: >> ``` >> kswapd0-89 [000] 64.887613: mm_vmscan_lru_shrink_inactive: >> nid=0 nr_scanned=64 nr_reclaimed=0 nr_dirty=0 nr_writeback=0 >> nr_congested=0 nr_immediate=0 nr_activate_anon=0 nr_activate_file=0 >> nr_ref_keep=0 nr_unmap_fail=0 priority=4 >> flags=RECLAIM_WB_FILE|RECLAIM_WB_ASYNC >> ``` >> Correct info like this: >> ``` >> <...>-9041 [006] 43.738481: mm_vmscan_lru_shrink_inactive: >> nid=0 nr_scanned=13 nr_reclaimed=0 nr_dirty=0 nr_writeback=0 >> nr_congested=0 nr_immediate=0 nr_activate_anon=9 nr_activate_file=0 >> nr_ref_keep=0 nr_unmap_fail=0 nr_promote=4 nr_demote=0 priority=12 >> flags=RECLAIM_WB_ANON|RECLAIM_WB_ASYNC >> ``` > Adding Jaewon & Kalesh to take a look. Thanks, Huan
| |