Messages in this thread | | | Date | Wed, 18 Oct 2023 21:53:58 +0200 | Subject | Re: [PATCH] tty: serial: samsung_tty: remove dead code | From | Krzysztof Kozlowski <> |
| |
On 18/10/2023 21:52, Krzysztof Kozlowski wrote: > On 18/10/2023 12:54, André Draszik wrote: >> From: André Draszik <andre.draszik@linaro.org> >> >> When support for various old platforms was removed in commit >> 1ea35b355722, s3c24xx_serial_ops also became unused here because > > Please use commit xyz ("foo") syntax as pointed out by checkpatch. > >> nothing sets port type TYPE_S3C24XX anymore. >> >> Remove s3c24xx_serial_ops and all the code that's unreachable now. >> >> Fixes: 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") >> Signed-off-by: André Draszik <andre.draszik@linaro.org> > > Rest looks good: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
.... and not entirely. You left earlycon.
Best regards, Krzysztof
| |