Messages in this thread | | | Date | Tue, 17 Oct 2023 08:35:11 -0700 | From | Ira Weiny <> | Subject | Re: [PATCH] cxl/pmu: Ensure put_device on pmu devices |
| |
Dave Jiang wrote: > >
[snip]
> > > > Properly call device_unregister() to free up the memory associated with > > the device. > > > > Fixes: 1ad3f701c399 ("cxl/pci: Find and register CXL PMU devices") > > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > Reviewed-by: Dave Jiang <dave.jiang@intel.com> > > Although I wonder if we can just give device_unregister() to devm_add_action_or_reset() directly. >
No because the action callback takes void * and device_unregister() takes a struct device *.
Ira
[snip]
| |