lkml.org 
[lkml]   [2023]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[patch V5 26/39] x86/microcode: Clean up mc_cpu_down_prep()
    Date
    From: Thomas Gleixner <tglx@linutronix.de>

    This function has nothing to do with suspend. It's a hotplug
    callback. Remove the bogus comment.

    Drop the pointless debug printk. The hotplug core provides tracepoints
    which track the invocation of those callbacks.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    ---
    arch/x86/kernel/cpu/microcode/core.c | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)
    ---
    --- a/arch/x86/kernel/cpu/microcode/core.c
    +++ b/arch/x86/kernel/cpu/microcode/core.c
    @@ -498,16 +498,10 @@ static int mc_cpu_online(unsigned int cp

    static int mc_cpu_down_prep(unsigned int cpu)
    {
    - struct device *dev;
    -
    - dev = get_cpu_device(cpu);
    + struct device *dev = get_cpu_device(cpu);

    microcode_fini_cpu(cpu);
    -
    - /* Suspend is in progress, only remove the interface */
    sysfs_remove_group(&dev->kobj, &mc_attr_group);
    - pr_debug("%s: CPU%d\n", __func__, cpu);
    -
    return 0;
    }

    \
     
     \ /
      Last update: 2023-10-17 23:26    [W:4.537 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site