Messages in this thread | | | Date | Mon, 16 Oct 2023 23:06:47 +0200 | Subject | Re: [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static | From | Helge Deller <> |
| |
On 10/16/23 22:04, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This is a global function that is only referenced as an initcall. This causes > a warning: > > drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes] > > Make it static instead. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
applied.
Thanks! Helge
> --- > drivers/video/fbdev/sa1100fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c > index 63e12a7c1100e..e14eb634cb944 100644 > --- a/drivers/video/fbdev/sa1100fb.c > +++ b/drivers/video/fbdev/sa1100fb.c > @@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = { > }, > }; > > -int __init sa1100fb_init(void) > +static int __init sa1100fb_init(void) > { > if (fb_get_options("sa1100fb", NULL)) > return -ENODEV;
| |