Messages in this thread | | | From | Jagath Jog J <> | Date | Sun, 15 Oct 2023 16:00:34 +0530 | Subject | Re: [PATCH v2 2/2] iio: imu: Add driver for BMI323 IMU |
| |
On Sat, Oct 14, 2023 at 10:16 PM Jonathan Cameron <jic23@kernel.org> wrote: > > On Fri, 13 Oct 2023 09:18:08 +0530 > Jagath Jog J <jagathjog1996@gmail.com> wrote: > > > The Bosch BMI323 is a 6-axis low-power IMU that provide measurements for > > acceleration, angular rate, and temperature. This sensor includes > > motion-triggered interrupt features, such as a step counter, tap detection, > > and activity/inactivity interrupt capabilities. > > > > The driver supports various functionalities, including data ready, FIFO > > data handling, and events such as tap detection, step counting, and > > activity interrupts. > > > > Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com> > Hi Jagath, > > Nice driver. > > We are rapidly approaching the end of this cycle and as this is a > large driver, I think it could do to remain on list at least a week > before I apply it or until it picks up some tags from others if that > happens sooner. Hence I'm afraid it might well sneak into next cycle.
Hi Jonathan
Thank you for reviewing, I understand the need for additional time to ensure a thorough review and to await feedback and tags from other reviewers. I'm okay with your schedule.
> > + > > +What: /sys/.../events/in_accel_gesture_tap_wait_dur > > +KernelVersion: 6.7 > > +Contact: linux-iio@vger.kernel.org > > +Description: > > + Timeout value for tap gesture confirmation. > > Units need to be specified. Seconds?
Yes, these are in seconds. I will add units in the next series.
> > source "drivers/iio/imu/bmi160/Kconfig" > > source "drivers/iio/imu/bno055/Kconfig" > > +source "drivers/iio/imu/bmi323/Kconfig" > Same on ordering.
Sure I will correct this in v3.
Regards Jagath
| |