Messages in this thread | | | Date | Sun, 15 Oct 2023 17:51:17 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH 5/6] staging: rtl8192u: Align descendant arguments |
| |
On Sun, 15 Oct 2023, Gilbert Adikankwu wrote:
> Align descendant arguments to the open parenthesis as per the "Linux > Kernel coding style" in Documentation/process/coding-style.rst > > Mute the following checkpatch error: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com> > --- > drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c > index 4f8629e47e82..c515b4773e37 100644 > --- a/drivers/staging/rtl8192u/r819xU_firmware.c > +++ b/drivers/staging/rtl8192u/r819xU_firmware.c > @@ -88,8 +88,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, > > index = tcb_desc->queue_index; > if (!priv->ieee80211->check_nic_enough_desc(dev, index) || > - (!skb_queue_empty(&priv->ieee80211->skb_waitQ[index])) || > - (priv->ieee80211->queue_stop)) { > + (!skb_queue_empty(&priv->ieee80211->skb_waitQ[index])) || > + (priv->ieee80211->queue_stop)) {
It's another change, but there are unnecessary parentheses here.
julia
> RT_TRACE(COMP_FIRMWARE, "=====================================================> tx full!\n"); > skb_queue_tail(&priv->ieee80211->skb_waitQ[tcb_desc->queue_index], skb); > } else { > -- > 2.34.1 > > >
| |