lkml.org 
[lkml]   [2023]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] nvme: update firmware version after commit
On Fri, Oct 13, 2023 at 06:34:20PM +0200, Daniel Wagner wrote:
> if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, NVME_CSI_NVM,
> - log, sizeof(*log), 0))
> + log, sizeof(*log), 0)) {
> dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");
> + goto out_free_log;
> + }
> +
> + afi = le64_to_cpu(log->afi);
> + if (afi & 0x30) {

That should be 'afi & 0x70'.

> + dev_info(ctrl->device,
> + "Firmware is activated after next Controller Level Reset\n");
> + goto out_free_log;
> + }
> +
> + memcpy(ctrl->subsys->firmware_rev, &log->frs[afi & 0x3],

and 'afi & 0x7'.

\
 
 \ /
  Last update: 2023-10-13 18:44    [W:0.182 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site