lkml.org 
[lkml]   [2023]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next v2 09/19] mm: mprotect: use a folio in change_pte_range()
On Fri, Oct 13, 2023 at 04:55:53PM +0800, Kefeng Wang wrote:
> Use a folio in change_pte_range() to save three compound_head() calls.

Yes, but here we have a change of behaviour, which should be argued
is desirable. Before if a partial THP was mapped, or a fs large
folio, we would do this to individual pages. Now we're doing it to the
entire folio. Is that desirable? I don't have the background to argue
either way.

> @@ -157,7 +159,7 @@ static long change_pte_range(struct mmu_gather *tlb,
> continue;
> if (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING &&
> !toptier)
> - xchg_page_access_time(page,
> + folio_xchg_access_time(folio,
> jiffies_to_msecs(jiffies));
> }

\
 
 \ /
  Last update: 2023-10-13 17:14    [W:0.292 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site