Messages in this thread | | | Date | Fri, 13 Oct 2023 17:36:13 +0800 | From | Xu Yilun <> | Subject | Re: [PATCH] fpga: xilinx-pr-decoupler: Fix unused xlnx_pr_decoupler_of_match warning for !CONFIG_OF |
| |
On Thu, Oct 12, 2023 at 02:21:48PM -0500, Rob Herring wrote: > Commit 8c966aadcc02 ("fpga: Use device_get_match_data()") dropped the
Hi rob:
Unfortunately I re-applied Commit 8c966aadcc02 and the previous commit id is lost.
Since the 2 patches are not upstreamed yet, could I just merge them into one?
Thanks, Yilun
> unconditional use of xlnx_pr_decoupler_of_match resulting in this > warning: > > drivers/fpga/xilinx-pr-decoupler.c:94:34: warning: unused variable 'xlnx_pr_decoupler_of_match' [-Wunused-const-variable] > > The fix is to drop of_match_ptr() which is not necessary because DT is > always used for this driver. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202310100247.Y7BFcalX-lkp@intel.com/ > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/fpga/xilinx-pr-decoupler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > index 0c012d0f616d..68835896f180 100644 > --- a/drivers/fpga/xilinx-pr-decoupler.c > +++ b/drivers/fpga/xilinx-pr-decoupler.c > @@ -167,7 +167,7 @@ static struct platform_driver xlnx_pr_decoupler_driver = { > .remove = xlnx_pr_decoupler_remove, > .driver = { > .name = "xlnx_pr_decoupler", > - .of_match_table = of_match_ptr(xlnx_pr_decoupler_of_match), > + .of_match_table = xlnx_pr_decoupler_of_match, > }, > }; > > -- > 2.42.0 >
| |