lkml.org 
[lkml]   [2023]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] scripts/show_delta: add __main__ judgement before main code
On Fri, Oct 13, 2023 at 6:29 AM Hu Haowen <2023002089@link.tyut.edu.cn> wrote:
>
> When doing Python programming it is a nice convention to insert the if
> statement `if __name__ == "__main__":` before any main code that does
> actual functionalities to ensure the code will be executed only as a
> script rather than as an imported module. Hence attach the missing
> judgement to show_delta.
>
> Signed-off-by: Hu Haowen <2023002089@link.tyut.edu.cn>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
> scripts/show_delta | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/show_delta b/scripts/show_delta
> index 28e67e178194..291ad65e3089 100755
> --- a/scripts/show_delta
> +++ b/scripts/show_delta
> @@ -125,4 +125,5 @@ def main():
> for line in lines:
> print (convert_line(line, base_time),)
>
> -main()
> +if __name__ == "__main__":
> + main()
> --
> 2.34.1
>


--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2023-10-13 22:28    [W:0.068 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site