lkml.org 
[lkml]   [2023]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] sched/schedutil: rework performance estimation

* Vincent Guittot <vincent.guittot@linaro.org> wrote:

> +
> + /* The minimum utilization returns the highest level between:
> + * - the computed DL bandwidth needed with the irq pressure which
> + * steals time to the deadline task.
> + * - The minimum bandwidth requirement for CFS.
> + */

Nit: please use the standard multi-line Linux kernel comment style.

> + /* The maximum hint is a soft bandwidth requirement which can be lower
> + * than the actual utilization because of max uclamp requirments
> */

Ditto.

> +unsigned long sugov_effective_cpu_perf(int cpu, unsigned long actual,
> + unsigned long min,
> + unsigned long max)
> +{
> + unsigned long target;
> + struct rq *rq = cpu_rq(cpu);
> +
> + if (rt_rq_is_runnable(&rq->rt))
> + return max;
> +
> + /* Provide at least enough capacity for DL + irq */
> + target = min;

s/ / /
s/irq/IRQ/

Thanks,

Ingo

\
 
 \ /
  Last update: 2023-10-13 20:21    [W:1.027 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site