lkml.org 
[lkml]   [2023]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v13 08/10] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280
From


On 10/12/2023 10:10 PM, Konrad Dybcio wrote:
>
>
> On 10/7/23 17:48, Krishna Kurapati wrote:
>> Add USB and DWC3 node for tertiary port of SC8280 along with multiport
>> IRQ's and phy's. This will be used as a base for SA8295P and SA8295-Ride
>> platforms.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
> [...]
>
>> +
>> +            interconnects = <&aggre1_noc MASTER_USB3_MP 0 &mc_virt
>> SLAVE_EBI1 0>,
>> +                    <&gem_noc MASTER_APPSS_PROC 0 &config_noc
>> SLAVE_USB3_MP 0>;
> Please use QCOM_ICC_TAG_ALWAYS from
> include/dt-bindings/interconnect/qcom,icc.h (like in sa8775p)
>
> With that I think it's good to go :)
>
Hi Konrad. Thanks for the review.

I see that the tags are used fr spi/i2c but not usb. So to maintain
uniformity, wanted to keep the same here.

Regards,
Krishna,

\
 
 \ /
  Last update: 2023-10-12 19:03    [W:0.322 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site