Messages in this thread | | | From | Alice Ryhl <> | Date | Thu, 12 Oct 2023 15:43:29 +0200 | Subject | Re: [PATCH] rust: macros: improve `#[vtable]` documentation |
| |
On Thu, Oct 12, 2023 at 3:22 PM Benno Lossin <benno.lossin@proton.me> wrote: > > Traits marked with `#[vtable]` need to provide default implementations > for optional functions. The C side represents these with `NULL` in the > vtable, so the default functions are never actually called. We do not > want to replicate the default behavior from C in Rust, because that is > not maintainable. Therefore we should use `build_error` in those default > implementations. The error message for that is provided at > `kernel::error::VTABLE_DEFAULT_ERROR`. > > Signed-off-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
| |