Messages in this thread | | | Date | Thu, 12 Oct 2023 14:20:04 +0200 | From | Greg KH <> | Subject | Re: [PATCH] staging: axis-fifo: Alignment should match open parenthesis |
| |
On Thu, Oct 12, 2023 at 02:13:38PM +0200, Bartłomiej Konecki wrote: > Fix 2 checks reported by checkpatch.pl in axis-fifo.c > for alignment should match open parenthesis > > Signed-off-by: Bartłomiej Konecki <bartekkonecki97@gmail.com> > --- > drivers/staging/axis-fifo/axis-fifo.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-)
Any specific reason you didn't cc: the staging mailing list like scripts/get_maintainer.pl suggested you do?
> > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 727b956aa231..ab758a527261 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf, > */ > mutex_lock(&fifo->read_lock); > ret = wait_event_interruptible_timeout(fifo->read_queue, > - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), > - read_timeout); > + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), > + read_timeout);
Does this now go over the max line length limit? Does this patch pass checkpatch.pl?
thanks,
greg k-h
| |