lkml.org 
[lkml]   [2023]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[net PATCH v2] octeon_ep: update BQL sent bytes before ringing doorbell
    Date
    Sometimes Tx is completed immediately after doorbell is updated, which
    causes Tx completion routing to update completion bytes before the
    same packet bytes are updated in sent bytes in transmit function, hence
    hitting BUG_ON() in dql_completed(). To avoid this, update BQL
    sent bytes before ringing doorbell.

    Fixes: 37d79d059606 ("octeon_ep: add Tx/Rx processing and interrupt support")
    Signed-off-by: Shinas Rasheed <srasheed@marvell.com>
    ---
    V1 -> V2: Call netdev_tx_sent_queue before memory barrier

    drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
    index dbc518ff8276..15420325aef3 100644
    --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
    +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
    @@ -715,6 +715,7 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb,
    hw_desc->dptr = tx_buffer->sglist_dma;
    }

    + netdev_tx_sent_queue(iq->netdev_q, skb->len);
    /* Flush the hw descriptor before writing to doorbell */
    wmb();

    @@ -726,7 +727,6 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb,
    wi = 0;
    iq->host_write_index = wi;

    - netdev_tx_sent_queue(iq->netdev_q, skb->len);
    iq->stats.instr_posted++;
    skb_tx_timestamp(skb);
    return NETDEV_TX_OK;
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-10-12 12:17    [W:7.925 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site