lkml.org 
[lkml]   [2023]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RFC 04/11] KVM: x86: hyper-v: Introduce kvm_hv_synic_auto_eoi_set()
    From
    Date
    У вт, 2023-10-10 у 18:02 +0200, Vitaly Kuznetsov пише:
    > As a preparation to making Hyper-V emulation optional, create a dedicated
    > kvm_hv_synic_auto_eoi_set() helper to avoid extra ifdefs in lapic.c
    >
    > No functional change intended.
    >
    > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    > ---
    > arch/x86/kvm/hyperv.h | 5 +++++
    > arch/x86/kvm/lapic.c | 2 +-
    > 2 files changed, 6 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/x86/kvm/hyperv.h b/arch/x86/kvm/hyperv.h
    > index f83b8db72b11..1897a219981d 100644
    > --- a/arch/x86/kvm/hyperv.h
    > +++ b/arch/x86/kvm/hyperv.h
    > @@ -105,6 +105,11 @@ int kvm_hv_synic_set_irq(struct kvm *kvm, u32 vcpu_id, u32 sint);
    > void kvm_hv_synic_send_eoi(struct kvm_vcpu *vcpu, int vector);
    > int kvm_hv_activate_synic(struct kvm_vcpu *vcpu, bool dont_zero_synic_pages);
    >
    > +static inline bool kvm_hv_synic_auto_eoi_set(struct kvm_vcpu *vcpu, int vector)
    > +{
    > + return to_hv_vcpu(vcpu) && test_bit(vector, to_hv_synic(vcpu)->auto_eoi_bitmap);
    > +}
    > +
    > void kvm_hv_vcpu_uninit(struct kvm_vcpu *vcpu);
    >
    > bool kvm_hv_assist_page_enabled(struct kvm_vcpu *vcpu);
    > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
    > index dcd60b39e794..0e80c1fdf899 100644
    > --- a/arch/x86/kvm/lapic.c
    > +++ b/arch/x86/kvm/lapic.c
    > @@ -2899,7 +2899,7 @@ int kvm_get_apic_interrupt(struct kvm_vcpu *vcpu)
    > */
    >
    > apic_clear_irr(vector, apic);
    > - if (to_hv_vcpu(vcpu) && test_bit(vector, to_hv_synic(vcpu)->auto_eoi_bitmap)) {
    > + if (kvm_hv_synic_auto_eoi_set(vcpu, vector)) {
    > /*
    > * For auto-EOI interrupts, there might be another pending
    > * interrupt above PPR, so check whether to raise another

    Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

    Best regards,
    Maxim Levitsky

    \
     
     \ /
      Last update: 2023-10-12 21:38    [W:4.102 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site