lkml.org 
[lkml]   [2023]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/10] PCI: Use FIELD_GET()
    On Tue, 10 Oct 2023 15:44:27 -0500
    Bjorn Helgaas <helgaas@kernel.org> wrote:

    > From: Bjorn Helgaas <bhelgaas@google.com>
    >
    > Use FIELD_GET() to remove dependences on the field position, i.e., the
    > shift value. No functional change intended.
    >
    > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

    It's a little unfortunate that some of the masks are called *_MASK and
    others are not (e.g. PCI_RBAR_CTRL_BAR_SIZE which is a mask).
    but given they are in include/uapi not sure we can tidy that up unless
    we add more defines that stick to consistent naming...

    Otherwise very nice.

    Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    \
     
     \ /
      Last update: 2023-10-11 12:51    [W:4.679 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site