lkml.org 
[lkml]   [2023]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next 3/6] Documentation: netlink: add a YAML spec for mptcp
hello, Jakub, thanks for looking at this!

On Wed, Oct 11, 2023 at 3:08 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 10 Oct 2023 21:21:44 +0200 Matthieu Baerts wrote:
> > +definitions:
> > + -
> > + type: enum
> > + name: event-type
> > + enum-name: mptcp_event_type
> > + name-prefix: mptcp_event_
>
> I think you can use - instead of _ here.
> For consistency with other families?

right, I will convert the whole spec.

>
> > + entries:
> > + -
> > + name: unspec
> > + value: 0
>
> 90% sure enums still start at 0, only attrs and msgs now default to 1.

Just checked, value:0 is not needed for enums: I will remove it

> > + -
> > + name: announced
> > + value: 6
> > + doc:
> > + token, rem_id, family, daddr4 | daddr6 [, dport]
> > + A new address has been announced by the peer.
> > + -
> > + name: removed
> > + value: 7
>
> Follows 6 so no need for value?

correct, will fix this too

> > + -
> > + name: addr6
> > + type: binary
> > + checks:
> > + min-len: 16
>
> Do you not want the exact length for this?
> If YNL doesn't support something just LMK, we add stuff as needed..

ohh yes, we had NLA_POLICY_EXACT_LEN before but ynl doesn't seem to
support it. I can try to add the support and include another patch at
the beginning of the series, is that ok?

--
davide

\
 
 \ /
  Last update: 2023-10-11 12:15    [W:0.050 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site