Messages in this thread | | | Date | Wed, 11 Oct 2023 09:45:11 +0100 | Subject | Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs | From | Srinivas Kandagatla <> |
| |
On 11/10/2023 09:33, Miquel Raynal wrote: > Hi Srinivas, > > srinivas.kandagatla@linaro.org wrote on Wed, 11 Oct 2023 09:27:20 +0100: > >> On 11/10/2023 08:15, Miquel Raynal wrote: >>>>> + >>>>> + nvmem_cells_group.bin_attrs = cells_attrs; >>>>> + >>>>> + ret = devm_device_add_groups(&nvmem->dev, nvmem_cells_groups); >>>>> + if (ret) >>>>> + goto unlock_mutex; >>>> This is going to create groups after the nvmem device is added, isn't this going to be problem with user space notifications? >>> Greg said it was not. I hope I understood correctly 😄 >>> >>> And anyway, cells have never been available to userspace, so there is >>> nothing userspace might expect yet? >> I agree, but once we add sysfs uapi then this is going to change. > > Can you elaborate? I'm not sure I follow you here. Is there still a > problem you fear or you think it's okay? > Now that we add cells to sysfs. AFAIU, By the time the userspace sees the udev event from this device we might not have cells populated.
--srini
> Thanks, > Miquèl
| |