Messages in this thread | | | Date | Wed, 11 Oct 2023 14:20:45 -0600 | Subject | Re: [PATCH] block: Don't invalidate pagecache for invalid falloc modes | From | Jens Axboe <> |
| |
On 10/11/23 2:12 PM, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode.
Fix looks fine, but would be nicer if we didn't have to duplicate the truncate_bdev_range() in each switch clause. Can we check this upfront instead?
Also, please wrap commit messages at 72-74 chars.
-- Jens Axboe
| |